Support for Kind Interface and Pointer to Facts

[rifqifatih]

I notice there is a similar Issue which was closed. However, I think there is some use case which can still be consider supporting interface / pointer.

I'm currently providing the Facts through REST API which can be in any arbitrary form, hence map[string]interface{}. But rule evaluation gives me

can not use data type of interface in EQ comparison

or

can not use data type of ptr in EQ comparison

if I use pointer.

Solution
I propose that in reflectmath.go/Evaluate* handles these "reference" type with e.g.:

func EvaluateEqual(left, right reflect.Value) (reflect.Value, error) {
	if left.Kind() == reflect.Pointer || left.Kind() == reflect.Interface {
		return EvaluateEqual(left.Elem(), right)
	}

	if right.Kind() == reflect.Pointer || right.Kind() == reflect.Interface {
		return EvaluateEqual(left, right.Elem())
	}
....
}

Would gladly make PR contribution but I would like to open this for discussion first to know what are the implications and if it's aligned with the design.

[newm4n]

Hi @rifqifatih

I can not figure any implication at this point. Please submit your PR including a unit test that shows whether your fix really works.
I will be very grateful if you can make a PR and make sure make test complete successfully.