Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templatizing strings for translation #28

Merged
merged 2 commits into from
Apr 14, 2015

Conversation

brainwane
Copy link
Contributor

Per bug 30, I have systematically found all, or nearly all, user-visible occurrences of hard-coded English strings in the hyperkitty/templates/hyperkitty/ directory and prepared them for translation/localisation/i18n as follows:

{% trans 'English message' %}

In some cases I have not been sure how to handle escaping, quoting, interaction with other variables, or pluralization; I'm happy to update this pull request in response to code review. Thanks.

@abompard
Copy link
Member

This looks nice, thanks for the work! However, the trans tag requires the {% load i18n %} tag at the top of the template file, and it is not always present. Could you add it in the missing files?

@brainwane
Copy link
Contributor Author

Thanks for the heads-up. Doing that now.

@brainwane
Copy link
Contributor Author

abompard, I've added the {% load i18n %} command to the files in templates/ where it wasn't present -- and in base.html I've moved it up from line 23 to line 2.

@abompard
Copy link
Member

Hey Sumana,
Sorry about the delay, but in the meantime I've change a few things on the templates, could you rebase your changes on the current HEAD? Thanks!

@brainwane
Copy link
Contributor Author

Here you go - rebased!

@abompard abompard merged commit 17a523e into hyperkitty:master Apr 14, 2015
@brainwane brainwane deleted the templatizing branch April 14, 2015 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants