self-Announce assumes that a chain signer is set #2458
Assignees
Labels
Comments
nambrot
added
bug
mattiekat
added a commit
that referenced
this issue
Aug 8, 2023
### Description This handles a bug where we did not default the chain signer to the validator signature for EVM chains and also handles the case where we might try to announce without setting a chain signer for other chains. ### Drive-by changes Not really a change but I looked into #2457 and I noticed the validators already check that signers are set for all destination chains so I think the error was just for validators which this PR fixes. ### Related issues - Fixes #2458 - Fixes #2457 ### Backward compatibility Yes ### Testing Unit Tests
nambrot
added a commit
that referenced
this issue
Aug 23, 2023
### Description This PR sets chain signer keys in the external secret. related to #2458 ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests --> Co-authored-by: josedev-union <josedev-union@users.noreply.github.com> Co-authored-by: Nam Chu Hoai <nambrot@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Validators specify the validator key via
--validator.key. However, the auto-announce feature introduced in #2177 uses the standard contract wrappers which are configured via--chains.[origin chain name].signer. If the validator does not specify the chain signer, I believe the validator will try to use the RPC's signer to submit a tx, leading to an error like #2457The text was updated successfully, but these errors were encountered: