Validator announce signers

[mattiekat]

Description

This handles a bug where we did not default the chain signer to the validator signature for EVM chains and also handles the case where we might try to announce without setting a chain signer for other chains.

Drive-by changes

Not really a change but I looked into #2457 and I noticed the validators already check that signers are set for all destination chains so I think the error was just for validators which this PR fixes.

Related issues

• Fixes self-Announce assumes that a chain signer is set #2458
• Fixes Agents should indicate when private keys are not configured #2457

Backward compatibility

Yes

Testing

Unit Tests

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (a5e1815) 65.39% compared to head (0d0facf) 65.39%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2617   +/-   ##
=======================================
  Coverage   65.39%   65.39%           
=======================================
  Files          89       89           
  Lines        1358     1358           
  Branches      182      182           
=======================================
  Hits          888      888           
  Misses        463      463           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tkporter]

Amazing, ty, this has been a huge point of confusion for people

[nambrot]

I noticed the validators already check that signers are set for all destination chains so I think the error was just for validators which this PR fixes.

I assume you mean relayer here?