Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ETH to be donated to a HypNative contract #2622

Closed
tkporter opened this issue Aug 8, 2023 · 4 comments · Fixed by #2671
Closed

Allow ETH to be donated to a HypNative contract #2622

tkporter opened this issue Aug 8, 2023 · 4 comments · Fixed by #2671
Assignees
@yorhodes
Labels
solana
Milestone
Sealevel MVP

Comments

@tkporter
Copy link
Collaborator

tkporter commented Aug 8, 2023 •
edited
Loading

The plan for bridging into Nautilus so that bridging gives a user the native Neon EVM token (i.e. ETH on that EVM) involves sending a bunch of ETH tokens to the HypNative contract without actually bridging the tokens. This ETH serves as a liquidity source for bridging in to that native warp route.

Atm, there is no fallback function on HypNative and the only payable function is transferRemote itself. We should add a function function donate() external payable; that anyone can call to donate funds to the HypNative contract

See #2621 for what this looks like in the stopgap version - need to add tests etc
@tkporter tkporter added this to the Sealevel MVP milestone Aug 8, 2023
@tkporter tkporter self-assigned this Aug 8, 2023
@tkporter tkporter mentioned this issue Aug 7, 2023
Closed
@avious00 avious00 added the solana label Aug 8, 2023
@avious00
Copy link
Contributor

@tkporter is this ready to close?

@yorhodes yorhodes mentioned this issue Aug 17, 2023
Merged
@nambrot nambrot assigned yorhodes and unassigned tkporter Aug 18, 2023
@avious00
Copy link
Contributor

avious00 commented Aug 31, 2023 •
edited
Loading

@yorhodes any updates on this? did we go with #2671 instead?

@tkporter
Copy link
Collaborator Author

Yeah we went with #2671 instead, just needs to get merged

@yorhodes
Copy link
Collaborator

yorhodes commented Sep 1, 2023

I have been trying to merge #2671 for a week
There is some unrelated CI flakiness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yorhodes yorhodes

Labels
solana
Projects
Hyperlane Tasks
Archived in project
Milestone
Sealevel MVP
Development

Successfully merging a pull request may close this issue.

Add receive fn to HypNative and Scaled variant hyperlane-xyz/hyperlane-monorepo
3 participants
@yorhodes @tkporter @avious00