Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add receive fn to HypNative and Scaled variant #2671

Merged
merged 22 commits into from
Sep 12, 2023
Merged

Add receive fn to HypNative and Scaled variant #2671

merged 22 commits into from
Sep 12, 2023

Conversation

yorhodes
Copy link
Collaborator

@yorhodes yorhodes commented Aug 17, 2023 •
edited
Loading

Description

Adds an extension to HypNative that scales TokenRouter message amount by configurable scale

Drive-by changes

Adds forge to token package

Related issues

Backward compatibility

Yes

Testing

Unit Tests

@codecov
Copy link

codecov bot commented Aug 17, 2023 •
edited
Loading

Codecov Report

Patch coverage: 21.42% and project coverage change: -0.34% ⚠️

Comparison is base (892cc5d) 64.50% compared to head (02462e9) 64.16%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2671      +/-   ##
==========================================
- Coverage   64.50%   64.16%   -0.34%     
==========================================
  Files          91       92       +1     
  Lines        1386     1398      +12     
  Branches      185      186       +1     
==========================================
+ Hits          894      897       +3     
- Misses        485      494       +9     
  Partials        7        7
Files Changed Coverage Δ
...ipt/token/contracts/extensions/HypNativeScaled.sol 0.00% <0.00%> (ø)
typescript/token/contracts/HypNative.sol 92.85% <50.00%> (+7.14%) ⬆️
typescript/token/contracts/libs/TokenRouter.sol 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yorhodes yorhodes requested a review from nambrot August 17, 2023 22:12
@yorhodes yorhodes changed the title Add deposit fn to HypNative and Scaled variant Add receive fn to HypNative and Scaled variant Aug 17, 2023
@yorhodes yorhodes mentioned this pull request Aug 17, 2023
Closed
@yorhodes yorhodes enabled auto-merge (squash) August 18, 2023 16:02
@avious00
Copy link
Contributor

@yorhodes bump to merge this

jmrossy
jmrossy reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only skimmed the ts changes but lgtm

@yorhodes yorhodes disabled auto-merge August 29, 2023 00:39
@yorhodes yorhodes enabled auto-merge (squash) August 29, 2023 00:39
@avious00 avious00 mentioned this pull request Aug 31, 2023
Closed
@yorhodes yorhodes merged commit 06124b4 into main Sep 12, 2023
20 of 22 checks passed
@yorhodes yorhodes deleted the native-scaled branch September 12, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrossy jmrossy jmrossy left review comments

@nambrot nambrot nambrot approved these changes

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

@asaj asaj Awaiting requested review from asaj

@mattiekat mattiekat Awaiting requested review from mattiekat

@aroralanuk aroralanuk Awaiting requested review from aroralanuk aroralanuk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow ETH to be donated to a HypNative contract
5 participants
@yorhodes @avious00 @nambrot @jmrossy @tkporter