Default fallback routing hook & ISM deployment fails #2895
Assignees
Comments
avious00
changed the title
aroralanuk
added a commit
that referenced
this issue
Dec 5, 2023
…#3009) ### Description - `DefaultFallbackRoutingIsm` needs the mailbox address which meant `DefaultFallbackRoutingIsmFactory` needed the mailbox address which is not ideal. So, I switched to non-factory deployments for this specific ISM type. - CLI does the ISM deployment inside core deployment instead of ISM first and core then. - Using the coreDeployer's `cachedAddresses` to store the latest ie toplevel ISM. ### Drive-by changes - fixed bug in `ismFactory.fromAddressMap` to not use the multiprovider filtered by contract map. This is undesirable as CLI user can provide chain selection and artifacts which doesn't include all the chains in the configs (and when we call `multiprovider.getDomainId` for the origin which may now be missing from the filtered MP, we get an error). ### Related issues - fixes #2895 ### Backward compatibility Yes ### Testing Manual through CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Default Fallback Routing ISM needs the Mailbox address at constructor time, unlike the other factories
The ProxyFactoryDeployer does not correctly populate this constructor argument.
The text was updated successfully, but these errors were encountered: