Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:enable DefaultFallbackRoutingIsm through non-factory deployment #3009

Merged
merged 11 commits into from
Dec 5, 2023

Conversation

aroralanuk
Copy link
Contributor

@aroralanuk aroralanuk commented Dec 1, 2023

Description

  • DefaultFallbackRoutingIsm needs the mailbox address which meant DefaultFallbackRoutingIsmFactory needed the mailbox address which is not ideal. So, I switched to non-factory deployments for this specific ISM type.
  • CLI does the ISM deployment inside core deployment instead of ISM first and core then.
  • Using the coreDeployer's cachedAddresses to store the latest ie toplevel ISM.

Drive-by changes

  • fixed bug in ismFactory.fromAddressMap to not use the multiprovider filtered by contract map. This is undesirable as CLI user can provide chain selection and artifacts which doesn't include all the chains in the configs (and when we call multiprovider.getDomainId for the origin which may now be missing from the filtered MP, we get an error).

Related issues

Backward compatibility

Yes

Testing

Manual through CLI

Copy link

changeset-bot bot commented Dec 1, 2023

🦋 Changeset detected

Latest commit: 8b05186

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@hyperlane-xyz/infra Patch
@hyperlane-xyz/cli Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/core Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

typescript/cli/src/deploy/core.ts Show resolved Hide resolved
typescript/cli/src/deploy/core.ts Outdated Show resolved Hide resolved
typescript/infra/src/govern/HyperlaneCoreGovernor.ts Outdated Show resolved Hide resolved
typescript/sdk/src/ism/HyperlaneIsmFactory.ts Outdated Show resolved Hide resolved
typescript/sdk/src/ism/HyperlaneIsmFactory.ts Outdated Show resolved Hide resolved
typescript/sdk/src/deploy/contracts.ts Outdated Show resolved Hide resolved
typescript/sdk/src/ism/HyperlaneIsmFactory.ts Outdated Show resolved Hide resolved
typescript/sdk/src/ism/HyperlaneIsmFactory.ts Outdated Show resolved Hide resolved
typescript/sdk/src/ism/HyperlaneIsmFactory.ts Outdated Show resolved Hide resolved
typescript/sdk/src/ism/HyperlaneIsmFactory.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks but mostly lgtm

typescript/cli/src/tests/routingIsm.test.ts Outdated Show resolved Hide resolved
typescript/cli/src/tests/routingIsm.test.ts Outdated Show resolved Hide resolved
typescript/sdk/src/hook/HyperlaneHookDeployer.ts Outdated Show resolved Hide resolved
@aroralanuk aroralanuk enabled auto-merge (squash) December 5, 2023 19:27
@aroralanuk aroralanuk merged commit e06fe0b into main Dec 5, 2023
9 of 18 checks passed
@aroralanuk aroralanuk deleted the kunal/fix-fallback-ism-issue branch December 5, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Default fallback routing hook & ISM deployment fails
3 participants