Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ChainMetadata types #2491

Merged
merged 7 commits into from
Jul 10, 2023
Merged

Refactor ChainMetadata types #2491

merged 7 commits into from
Jul 10, 2023

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Jul 6, 2023 •
edited
Loading

Description

  • Refactor ChainMetadata types into new folder
  • Create metadata extensions for deployment artifacts, and agent config
  • Remove explicit ChainMetadata interface and infer from zod schema instead

Related issues

Implements new schema discussed in:

Fixes #2214

Backward compatibility

No: users of chain metadata configs would need to slightly modify their shape (the rpcUrl field)

@jmrossy jmrossy requested review from nambrot and mattiekat July 6, 2023 22:29
This was referenced Jul 10, 2023
Closed
Closed
@jmrossy jmrossy marked this pull request as ready for review July 10, 2023 20:38
@jmrossy jmrossy requested a review from nambrot July 10, 2023 20:39
@jmrossy jmrossy merged commit 395a069 into main Jul 10, 2023
12 of 20 checks passed
@jmrossy jmrossy deleted the rossy/configs-2214 branch July 10, 2023 21:50
@mattiekat mattiekat mentioned this pull request Aug 15, 2023
Merged
mattiekat added a commit that referenced this pull request Aug 16, 2023
@mattiekat
Agent Config Typescript Definitions (#2658)
d88fd4c 
### Description

Updates the typescript definitions based on the rust code. This is the
first in a series of PRs for handling Rust config streamlining.

### Drive-by changes

- A couple of the core types I refined, please validate the definitions.

### Related issues

Progress on #2215 
Relates to #2491

### Backward compatibility

Yes

### Testing

Unit Tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asaj asaj asaj approved these changes

@mattiekat mattiekat Awaiting requested review from mattiekat

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

@yorhodes yorhodes Awaiting requested review from yorhodes yorhodes is a code owner

@nambrot nambrot Awaiting requested review from nambrot

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Streamline config shapes (typescript)
3 participants
@jmrossy @nambrot @asaj