Kunal/v3 hooks #2580
Merged
Kunal/v3 hooks #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v3 #2580 +/- ##
==========================================
- Coverage 62.51% 61.18% -1.34%
==========================================
Files 95 99 +4
Lines 1430 1466 +36
Branches 198 206 +8
==========================================
+ Hits 894 897 +3
- Misses 529 562 +33
Partials 7 7
☔ View full report in Codecov by Sentry. |
yorhodes
reviewed
Aug 1, 2023
solidity/contracts/interfaces/optimism/ICrossDomainMessenger.sol
Outdated
Show resolved
Hide resolved
yorhodes
approved these changes
Aug 2, 2023
| * @param _messageId Hyperlane ID for the message. | ||
| */ | ||
| function verifyMessageId(bytes32 _messageId) external virtual { | ||
| _isAuthorized(); |
There was a problem hiding this comment.
I would have isAuthorized return a bool as the name suggests and require here
Comment on lines
+4
to
+10
| library OPStackHookMetadata { | ||
| function msgValue(bytes calldata _metadata) | ||
| internal | ||
| pure | ||
| returns (uint256) | ||
| { | ||
| return uint256(bytes32(_metadata[0:32])); |
There was a problem hiding this comment.
can you add a layout in natspec similar to the other metadata libs
Merged
yorhodes
pushed a commit
that referenced
this pull request
Aug 18, 2023
### Description - Adding Optimism Hook for MailboxV3 ### Drive-by changes - dispatch function with hookMetadata ### Related issues - hyperlane-xyz/issues#513 ### Backward compatibility No ### Testing None
Closed
yorhodes
pushed a commit
that referenced
this pull request
Sep 13, 2023
Use mailbox callback to authenticate messages in hooks where necessary (#2609) Co-authored-by: Kunal Arora <55632507+aroralanuk@users.noreply.github.com>
hashableric
pushed a commit
to many-things/hyperlane-monorepo
that referenced
this pull request
Oct 14, 2023
- Adding Optimism Hook for MailboxV3 - dispatch function with hookMetadata - https://github.com/hyperlane-xyz/issues/issues/513 No None
hashableric
pushed a commit
to many-things/hyperlane-monorepo
that referenced
this pull request
Oct 16, 2023
- Adding Optimism Hook for MailboxV3 - dispatch function with hookMetadata - https://github.com/hyperlane-xyz/issues/issues/513 No None
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
Related issues
Backward compatibility
No
Testing
None