Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGP Tooling #2602

Merged
merged 27 commits into from
Aug 4, 2023
Merged

IGP Tooling #2602

merged 27 commits into from
Aug 4, 2023

Conversation

mattiekat
Copy link
Contributor

@mattiekat mattiekat commented Aug 2, 2023

Description

Adds support for deploying IGPs and initial setup. Also extends the E2E tests to support these changes.

  • Deploy an IGP
  • Configure gas oracle data on IGPs
  • Configure gas overhead amounts for overhead IGP
  • Adds new config files to support the above
  • Adds support for u128 in serde_json

Drive-by changes

  • Minor code cleanup around unused build cmd args
  • Refactored transaction submission to prevent common errors.
  • Cleaned up arg passing in the core commands

Related issues

Fixes #2500

Backward compatibility

Yes-ish, slightly changes some sealevel commands but mostly the same. See the e2e test if in doubt.

Testing

Manual
Unit Tests

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d901ca2) 65.39% compared to head (7a70377) 65.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2602   +/-   ##
=======================================
  Coverage   65.39%   65.39%           
=======================================
  Files          89       89           
  Lines        1358     1358           
  Branches      182      182           
=======================================
  Hits          888      888           
  Misses        463      463           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rust/hyperlane-core/src/utils.rs Outdated Show resolved Hide resolved
rust/utils/run-locally/src/solana.rs Outdated Show resolved Hide resolved
@mattiekat mattiekat marked this pull request as ready for review August 3, 2023 23:53
@mattiekat mattiekat requested a review from asaj as a code owner August 3, 2023 23:53
@mattiekat mattiekat enabled auto-merge (squash) August 3, 2023 23:53
@mattiekat mattiekat disabled auto-merge August 3, 2023 23:53
@mattiekat mattiekat merged commit 9045f83 into main Aug 4, 2023
24 checks passed
@mattiekat mattiekat deleted the mattie/solana/igp-tooling branch August 4, 2023 00:17
daniel-savu added a commit that referenced this pull request Aug 30, 2023
### Description
 
Depends on #2583

Indexes IGP payments related to the relayer's data pda address. Unless
this address is specified in the config (`sealevel.relayer_account `),
no filtering is applied and all IGP payments are stored in the local
database.

<!--
What's included in this PR?
-->

### Drive-by changes

- Sets `HYP_BASE_GASPAYMENTENFORCEMENT` in `run-locally` for the
relayer, to test that it correctly indexes the IGP payment before
submitting the message
- A new config section (`sealevel`) is added to the relayer
- The `MessageIndexer` trait is replaced with
`SequenceIndexer<HyperlaneMessage>`, renaming `fetch_count_at_tip` to
`sequence_at_tip`. `SequenceIndexer` is now common to both the message
and igp indexers.
- The `parse_addr` macro is modified so it can be reused when parsing
the sealevel relayer address config too
- `rust/utils/sealevel-test.bash` is included because I was using it to
test locally, but I can remove it if the sealevel e2e test already does
all the steps there @mattiecnvr
- Performs a `try_into` conversion that can be removed once
#2610 is done

### Related issues

- Fixes #2501


### Backward compatibility

<!--
Are these changes backward compatible? Are there any infrastructure
implications, e.g. changes that would prohibit deploying older commits
using this infra tooling?

Yes/No
-->

### Testing

<!--
What kind of testing have these changes undergone?
-->
e2e tests but the pipeline is failing, likely fixed by
#2602

---------

Co-authored-by: Trevor Porter <trkporter@ucdavis.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Sealevel: basic tooling to deploy IGPs and configure them with gas oracle data
2 participants