-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sealevel igp indexing #2585
Sealevel igp indexing #2585
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2585 +/- ##
=======================================
Coverage 64.50% 64.50%
=======================================
Files 91 91
Lines 1386 1386
Branches 185 185
=======================================
Hits 894 894
Misses 485 485
Partials 7 7 ☔ View full report in Codecov by Sentry. |
a246435
to
e262d0a
Compare
46b7374
to
3e68130
Compare
3e68130
to
1fb6dbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved assuming the E2E tests get resolved
This reverts commit 3cb04f9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only thing that's important is my question about backward sequence indexing
f413f5e
to
9fe1f66
Compare
… migration" This reverts commit 9fe1f66.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! some suggestions and questions
rust/sealevel/environments/local-e2e/sealeveltest1/core/program-ids.json
Outdated
Show resolved
Hide resolved
This reverts commit a894535.
Description
Depends on #2583
Indexes IGP payments related to the relayer's data pda address. Unless this address is specified in the config (
sealevel.relayer_account
), no filtering is applied and all IGP payments are stored in the local database.Drive-by changes
HYP_BASE_GASPAYMENTENFORCEMENT
inrun-locally
for the relayer, to test that it correctly indexes the IGP payment before submitting the messagesealevel
) is added to the relayerMessageIndexer
trait is replaced withSequenceIndexer<HyperlaneMessage>
, renamingfetch_count_at_tip
tosequence_at_tip
.SequenceIndexer
is now common to both the message and igp indexers.parse_addr
macro is modified so it can be reused when parsing the sealevel relayer address config toorust/utils/sealevel-test.bash
is included because I was using it to test locally, but I can remove it if the sealevel e2e test already does all the steps there @mattiecnvrtry_into
conversion that can be removed once 64-bit block heights #2610 is doneRelated issues
Backward compatibility
Testing
e2e tests but the pipeline is failing, likely fixed by #2602