Modifying IGP to be a hook #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description - Adding default hook using custom config ### Drive-by changes - `postDispatch` is now public ### Related issues - v3 ### Backward compatibility Yes ### Testing None
aroralanuk
requested review from
mattiekat,
tkporter,
asaj and
yorhodes
as code owners
yorhodes
reviewed
Aug 11, 2023
solidity/contracts/isms/hook/AbstractMessageIdAuthorizedIsm.sol
Outdated
Show resolved
Hide resolved
solidity/contracts/libs/LibBit.sol
Outdated
yorhodes
approved these changes
Aug 14, 2023
yorhodes
added a commit
that referenced
this pull request
Aug 18, 2023
- IGP as a standalone hook, implementing postDispatch to call payForGas directly - Setting a DEFAULT_GAS_USAGE if metadata not specified and message.senderAddress() as refund address if not specified. - None Fixes hyperlane-xyz/issues#511 Yes, same interface as the previous IGP but for Mailbox V3 Unit Tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>
Closed
yorhodes
added a commit
that referenced
this pull request
Sep 13, 2023
- IGP as a standalone hook, implementing postDispatch to call payForGas directly - Setting a DEFAULT_GAS_USAGE if metadata not specified and message.senderAddress() as refund address if not specified. - None Fixes hyperlane-xyz/issues#511 Yes, same interface as the previous IGP but for Mailbox V3 Unit Tests --------- Co-authored-by: Yorke Rhodes <yorke@hyperlane.xyz>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
Related issues
Fixes https://github.com/hyperlane-xyz/issues/issues/511
Backward compatibility
Yes, same interface as the previous IGP but for Mailbox V3
Testing
Unit Tests