-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent Config Base Parsing #2665
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2665 +/- ##
=======================================
Coverage 64.61% 64.61%
=======================================
Files 90 90
Lines 1379 1379
Branches 182 182
=======================================
Hits 891 891
Misses 481 481
Partials 7 7 ☔ View full report in Codecov by Sentry. |
mattiekat
requested review from
yorhodes,
jmrossy,
tkporter and
asaj
as code owners
August 16, 2023 20:46
daniel-savu
reviewed
Aug 18, 2023
daniel-savu
reviewed
Aug 18, 2023
daniel-savu
reviewed
Aug 18, 2023
daniel-savu
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a big one for #2215...
Drive-by changes
unwrap()
I noticed since these cause difficult to debug errors in prod.Related issues
Backward compatibility
Yes
Testing
Manual (E2E only for now to make sure I did not break the old config format)