Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation hook deployer #2769

Merged
merged 40 commits into from
Oct 5, 2023
Merged

Aggregation hook deployer #2769

merged 40 commits into from
Oct 5, 2023

Conversation

aroralanuk
Copy link
Contributor

@aroralanuk aroralanuk commented Oct 2, 2023

Description

  • deploying AggregationHookFactory
  • configure aggregation of IGP and merkle in e2e tests

Drive-by changes

  • adjust typechain factories for inheritance
  • bubble up required hook revert reasons instead of underflowing when msg.value < requiredHook.quote

Related issues

Backward compatibility

Yes

Testing

Unit/e2e

@aroralanuk aroralanuk changed the base branch from v3 to hyperlane-interceptor-deployer October 2, 2023 21:02
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #2769 (2fc9921) into v3 (388824d) will not change coverage.
The diff coverage is n/a.

❗ Current head 2fc9921 differs from pull request most recent head 950dca9. Consider uploading reports for the commit 950dca9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##               v3    #2769   +/-   ##
=======================================
  Coverage   64.49%   64.49%           
=======================================
  Files          97       97           
  Lines         966      966           
  Branches      100      100           
=======================================
  Hits          623      623           
  Misses        307      307           
  Partials       36       36           
Components Coverage Δ
core 51.61% <ø> (ø)
hooks 67.93% <ø> (ø)
isms 68.65% <ø> (ø)
token 84.84% <ø> (ø)
middlewares 73.17% <ø> (ø)

@aroralanuk aroralanuk marked this pull request as ready for review October 2, 2023 22:56
Base automatically changed from hyperlane-interceptor-deployer to v3 October 2, 2023 23:33
@yorhodes yorhodes enabled auto-merge (squash) October 5, 2023 01:24
@yorhodes yorhodes disabled auto-merge October 5, 2023 20:26
@yorhodes yorhodes merged commit d69d76a into v3 Oct 5, 2023
6 checks passed
@yorhodes yorhodes deleted the aggregation-hook-deployer branch October 5, 2023 20:26
@yorhodes yorhodes mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants