Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate router test v3 #2796

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Migrate router test v3 #2796

merged 6 commits into from
Nov 9, 2023

Conversation

ottbunn
Copy link
Contributor

@ottbunn ottbunn commented Oct 12, 2023

Description

migrate router tests from hardhat to foundry

Drive-by changes

no

Related issues

Backward compatibility

no

Testing

changing the test itself

@ottbunn ottbunn marked this pull request as ready for review October 12, 2023 00:34
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #2796 (80acbf4) into v3 (e4eed2a) will increase coverage by 1.17%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2796      +/-   ##
==========================================
+ Coverage   66.86%   68.04%   +1.17%     
==========================================
  Files          99       99              
  Lines        1017     1017              
  Branches      106      106              
==========================================
+ Hits          680      692      +12     
+ Misses        296      286      -10     
+ Partials       41       39       -2     
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 71.42% <ø> (ø)
isms 71.22% <ø> (+0.71%) ⬆️
token 58.41% <ø> (ø)
middlewares 81.46% <ø> (ø)

solidity/test/router.t.sol Outdated Show resolved Hide resolved
solidity/test/router.t.sol Outdated Show resolved Hide resolved
solidity/test/router.t.sol Outdated Show resolved Hide resolved
@ottbunn ottbunn requested a review from yorhodes October 19, 2023 18:52
@ottbunn
Copy link
Contributor Author

ottbunn commented Oct 25, 2023

(reminder) 🛎️ updated

Copy link
Collaborator

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for the contribution!

@yorhodes yorhodes mentioned this pull request Nov 8, 2023
@yorhodes yorhodes enabled auto-merge (squash) November 8, 2023 23:45
@yorhodes yorhodes merged commit 5c3e2aa into hyperlane-xyz:v3 Nov 9, 2023
17 checks passed
@yorhodes yorhodes mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants