-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate router test v3 #2796
Merged
Merged
Migrate router test v3 #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottbunn
requested review from
yorhodes,
tkporter and
aroralanuk
as code owners
October 12, 2023 00:34
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v3 #2796 +/- ##
==========================================
+ Coverage 66.86% 68.04% +1.17%
==========================================
Files 99 99
Lines 1017 1017
Branches 106 106
==========================================
+ Hits 680 692 +12
+ Misses 296 286 -10
+ Partials 41 39 -2
|
yorhodes
reviewed
Oct 17, 2023
(reminder) 🛎️ updated |
yorhodes
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks for the contribution!
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
migrate router tests from hardhat to foundry
Drive-by changes
no
Related issues
Backward compatibility
no
Testing
changing the test itself