Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove supports1559 #460

Merged
merged 4 commits into from
May 19, 2022
Merged

Remove supports1559 #460

merged 4 commits into from
May 19, 2022

Conversation

nambrot
Copy link
Contributor

@nambrot nambrot commented May 19, 2022

celo-org/optics-monorepo@7954faf on the optics-monorepo added the supports1559 logic that explicitly sets the transaction type. Because of it, we have been mistakenly assuming that to have type 2 transactions, the transaction config has to manually specify the fields in the overrides. It turns out that

  1. ethers.rs supports 1559 automatically by detecting support via the RPC
  2. We actually haven't been setting the tx type anyways due to the recent SDK refactor where fixOverrides is only used in getMultiProviderFromConfigAndSigner which is only used in the test environment.

Thus this PR removes that special casing. It also treats the sdk's IChainConnectionConfig as sufficient for infra's TransactionConfigs. In a future PR, those types should probably be merged

This PR also removes ChainConnections mutative functions as they are currently unused. The original intention is to be able to change ChainConnection fields at runtime. It's unclear to me when that really would be useful, with the possible exception of changing the signer. However, the abstraction change that we underwent with the SDK overhaul doesn't account for state changes in ChainConnection/MultiProvider anyways, so we'll have to think about it from sctrach

Fixes #366

Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling Yorke has more context on the other changes (like the change to getMultiProviderFromConfigAndSigner and the code removal)

typescript/deploy/src/config.ts Show resolved Hide resolved
@nambrot nambrot enabled auto-merge (squash) May 19, 2022 20:36
@nambrot nambrot merged commit 0fd42b6 into main May 19, 2022
@nambrot nambrot deleted the nambrot/remove-supports-1559 branch May 19, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify TransactionConfigs to use EIP 1559 when deploying
2 participants