Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
celo-org/optics-monorepo@7954faf on the optics-monorepo added the
supports1559
logic that explicitly sets the transaction type. Because of it, we have been mistakenly assuming that to have type 2 transactions, the transaction config has to manually specify the fields in the overrides. It turns out thatfixOverrides
is only used ingetMultiProviderFromConfigAndSigner
which is only used in thetest
environment.Thus this PR removes that special casing. It also treats the sdk's
IChainConnectionConfig
as sufficient for infra'sTransactionConfig
s. In a future PR, those types should probably be mergedThis PR also removes
ChainConnection
s mutative functions as they are currently unused. The original intention is to be able to changeChainConnection
fields at runtime. It's unclear to me when that really would be useful, with the possible exception of changing the signer. However, the abstraction change that we underwent with the SDK overhaul doesn't account for state changes inChainConnection
/MultiProvider
anyways, so we'll have to think about it from sctrachFixes #366