This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: Add structured claims option #3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3481 +/- ##
==========================================
- Coverage 87.68% 87.67% -0.01%
==========================================
Files 350 350
Lines 47670 47762 +92
==========================================
+ Hits 41799 41876 +77
- Misses 4355 4365 +10
- Partials 1516 1521 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sandrask
force-pushed
the
issue-3478
branch
2 times, most recently
from
19e827d
to
41c5c4b
Compare
bstasyszyn
approved these changes
Jan 18, 2023
| @@ -756,4 +759,26 @@ func buildJWS(signer afjose.Signer, claims interface{}) (string, error) { | |||
| return jws.SerializeCompact(false) | |||
| } | |||
|
|
|||
| func printObject(t *testing.T, name string, obj interface{}) { | |||
There was a problem hiding this comment.
Should mark helper func with t.Helper()
Added: - structured claims option to issuer - verify digests in structured claims for holder - structured claims processing to verifier Closes hyperledger-archives#3478 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
fqutishat
approved these changes
Jan 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
Closes #3478
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com