This repository has been archived by the owner on Sep 22, 2023. It is now read-only.
Feature/Electron 12 #252
Merged
Feature/Electron 12 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the recommendation of @dbluhm, I have taken a look at migrating the work on the ARIES Toolbox from using Electron 9 to Electron 12. @burdettadam found and recommended the use of mubaidr/vue-electron-template, which has been paramount in this upgrade. This change involved moving the minimal amount of code from hyperledger/aries-toolbox into the vue electron template until things started to work. Once the UI was able to show up, and a connection to an instance of hyperledger/aries-cloudagent-python could be established and feature list discovered, success was determined in this endeavor. There do appear to be a couple of console errors at this time that may need cleaning up before this change can be considered complete. Once everything is working, this should fix hyperledger-archives#237. Successful connection via loca.lt has been determined. It is assumed that loca.lt uses Let's Encrypt certificates as described in the aforementioned issue. I plan to spend Monday working on fixes for the remaining console errors that I saw earlier, clean up any unnecessary code changes, and get a PR ready for the upstream repo. Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
Since the structure of this repository is now based off of mubaidr/vue-electron-template instead of SimulatedGREG/electon-vue, the credits inside of the README.me file have been updated to reflect the change of base. Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
An error that I noticed getting thrown was that `msg.result` was undefined and did not have the property `did` associated with it. Better than an error, I have made it so the code only runs if msg.result is defined. `share.fetch_dids();` is also in this block because it would not run anyways if the line above it threw an exception. If `msg.result` is `undefined`, we now return a warning that no public did was found. Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
This commit contains all that is needed to upgrade the ARIES Toolbox from Electron 9 to Electron 12. This fixes hyperledger-archives#237 See merged commits for more details about the changes made Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
Signed-off-by: Micah Peltier <micah6_8@yahoo.com>
Signed-off-by: Micah Peltier <micah6_8@yahoo.com>
|
@frostyfrog I attempted a merge in from main but I think the changes were not properly applied. We should make sure those changes make it in then prioritize merging this before other PRs. |
dbluhm
approved these changes
Jan 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details about the changes being made/proposed.