-
Notifications
You must be signed in to change notification settings - Fork 96
[FABCE-148] Update fabric dep in integration test #29
[FABCE-148] Update fabric dep in integration test #29
Conversation
- use fabric `release-1.4` branch to pull in fix for nexus repo change required to build fabric components Signed-off-by: Swetha Repakula <srepaku@us.ibm.com>
looking good |
else | ||
FABRIC_VERSION=$(git -C ${FABRIC_DIR} describe --abbrev=0) | ||
if [[ ${FABRIC_VERSION} != "v1.4.0" ]]; then | ||
if [[ ${FABRIC_VERSION} != "v1.4.4" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release-1.4 branch is going to float, can we check for the commit with
git merge-base --is-ancestor 52e51550b0b8f08b2f3c9052e851a82c002d406f HEAD
hyperledger/fabric@52e5155
@@ -22,3 +22,5 @@ replace github.com/go-kit/kit => github.com/go-kit/kit v0.7.0 | |||
replace github.com/hyperledger/burrow => github.com/hyperledger/burrow v0.24.4 | |||
|
|||
replace github.com/fsouza/go-dockerclient => github.com/fsouza/go-dockerclient v1.3.0 | |||
|
|||
replace github.com/hyperledger/fabric => github.com/hyperledger/fabric v1.4.4-0.20200211223613-5eaae3a9940d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think about updating vendor here, how do you figure this out?
@@ -176,6 +178,8 @@ github.com/spf13/jwalterweatherman | |||
github.com/spf13/pflag | |||
# github.com/spf13/viper v1.4.0 | |||
github.com/spf13/viper | |||
# github.com/sykesm/zap-logfmt v0.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the tool automatically make these comments?
the three failing tests are failing about contacting the orderer, but the one other test that would do that, the e2e test, is not failing. |
e2e doesn't use fab3, so the libs for e2e talking to the orderer are updated with this update, whereas fab3 is not. |
some maybe relevant portions from fab3 sdk logs
will try to roll back and see what it looks like when it works. |
release-1.4
branch to pull in fix for nexus repo changerequired to build fabric components
Signed-off-by: Swetha Repakula srepaku@us.ibm.com
make basic-checks
make unit-test
make integration-test