This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Remove unused parameter from Iroha CLI #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2018 19:39
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
igor-egorov
added
needs-review
l4l
approved these changes
Sep 9, 2018
truongnmt
approved these changes
Sep 12, 2018
lebdron
approved these changes
Sep 14, 2018
added 2 commits
September 18, 2018 10:42
…add-ast-qty Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
bakhtin
pushed a commit
that referenced
this pull request
Nov 2, 2018
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Egorov igor@soramitsu.co.jp
Description of the Change
Recently the list of parameters of AddAssetQuantity command was changed (AccountId field was removed).
Iroha CLI was not completely updated to address the change.
UPD
It turned out that SubtractAssetQuantity command was not implemented at all.
This pr also adds its implementation to Iroha-cli.
Benefits
Now it is possible to issue AddAssetQuantity via Iroha CLI again.
Possible Drawbacks
None
Usage Examples or Tests