Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor verify signature and envelope generation #20

Merged
merged 4 commits into from
Jan 30, 2023
Merged

Refactor verify signature and envelope generation #20

merged 4 commits into from
Jan 30, 2023

Conversation

olaeseane
Copy link
Contributor

To support proper serialisation of the envelope data from frontend to chaincode

Signed-off-by: olaeseane olaesean@gmail.com

@olaeseane
Refactor verify signature and envelope generation
5825ca1 
Signed-off-by: olaeseane <olaesean@gmail.com>
@olaeseane olaeseane requested a review from a team as a code owner January 26, 2023 13:42
@coveralls
Copy link

coveralls commented Jan 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4041808153

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 57.18%
Files with Coverage Reduction New Missed Lines %
gateway/chaincode_instance_event_service.go 1 75.27%
Totals Coverage Status
Change from base Build 4004560817: 0.2%
Covered Lines: 3926
Relevant Lines: 6866
💛 - Coveralls

@olaeseane
Custom time layout const
b6747bc 
Signed-off-by: olaeseane <olaesean@gmail.com>
@olaeseane
Change pubkey, sig, hash_to_sign to base58 format
e2159ef 
Signed-off-by: olaeseane <olaesean@gmail.com>
@olaeseane
Add decoding json to base54 in tests
b8d31fe 
Signed-off-by: olaeseane <olaesean@gmail.com>
@vitiko vitiko merged commit e3844d2 into hyperledger-labs:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitiko vitiko vitiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olaeseane @coveralls @vitiko