Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance voting functions for chaincode_ops #12

Merged

Conversation

satota2
Copy link
Contributor

@satota2 satota2 commented Sep 15, 2021

This PR enhances voting functions for chaincode_ops as follows:

  • Improve voting acceptance specifications
    • Not accept overwriting of votes from the same organization
    • Not accept voting after the decision (should explicitly raise an error)
  • Support rejection of proposal
  • Support withdrawal of proposal

The new chaincode_ops can cover a series of state transitions of chaincode update proposals,
including proposal rejection and withdrawal, although it is not yet flexible enough.

…ncode_ops

This patch updates the voting specifications for chaincode_ops as
follows:
- Not accept voting after the decision (will occur an error)
- Not accept overwriting of votes from the same organization

Signed-off-by: Tatsuya Sato <tatsuya.sato.so@hitachi.com>
…r chaincode_ops

Signed-off-by: Tatsuya Sato <tatsuya.sato.so@hitachi.com>
…incode_ops

Signed-off-by: Tatsuya Sato <tatsuya.sato.so@hitachi.com>
Signed-off-by: Tatsuya Sato <tatsuya.sato.so@hitachi.com>
Signed-off-by: Tatsuya Sato <tatsuya.sato.so@hitachi.com>
Signed-off-by: Tatsuya Sato <tatsuya.sato.so@hitachi.com>
…_ops

Signed-off-by: Tatsuya Sato <tatsuya.sato.so@hitachi.com>
…e_ops

Signed-off-by: Tatsuya Sato <tatsuya.sato.so@hitachi.com>
…r voting functions

This patch updates the design documents on state transitions of ops proposals
and their voting functions. design has been applied to the implementation of
`chaincode_ops`.

Signed-off-by: Tatsuya Sato <tatsuya.sato.so@hitachi.com>
Copy link
Contributor

@shimos shimos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shimos shimos merged commit 576306c into hyperledger-labs:main Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants