Skip to content

Commit

Permalink
fix parameter names in demo and demo documentation
Browse files Browse the repository at this point in the history
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
  • Loading branch information
andrewwhitehead committed Nov 12, 2019
1 parent f2d862c commit 7a7c556
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion demo/AcmeDemoWorkshop.md
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ with the following code:
}
offer_request = {
"connection_id": agent.connection_id,
"credential_definition_id": credential_definition_id,
"cred_def_id": credential_definition_id,
"comment": f"Offer on cred def id {credential_definition_id}",
"credential_preview": CredentialPreview(
attributes=CredAttrSpec.list_plain(
Expand Down
2 changes: 1 addition & 1 deletion demo/AriesOpenAPIDemo-DMV.md
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ Issuing a credential from the DMV agent to Alice’s agent is easy. In the DMV b

First, scroll back up to the **`GET /connections`** API endpoint and execute it. From the result, find the the `connection_id` and copy the value. Go back to the **`POST /issue-credential/send`** section and paste it as the value for the `connection_id`.

Next, scroll down to the **`POST /credential-definitions`** section that you executed in the previous step. Expand it (if necessary) and find and copy the value of the `credential_definition_id`. You could also get it from the Indy Ledger browser tab, or from earlier in this tutorial. Go back to the **`POST /issue-credential/send`** section and paste it as the value for the `credential_defintion_id`.
Next, scroll down to the **`POST /credential-definitions`** section that you executed in the previous step. Expand it (if necessary) and find and copy the value of the `credential_definition_id`. You could also get it from the Indy Ledger browser tab, or from earlier in this tutorial. Go back to the **`POST /issue-credential/send`** section and paste it as the value for the `cred_def_id`.

Finally, for the credential values, put the following between the `attributes` square brackets:

Expand Down
2 changes: 1 addition & 1 deletion demo/AriesOpenAPIDemo.md
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ OK, the one time setup work for issuing a credential complete. We can now issue

Issuing a credential from the Faber agent to Alice’s agent is done with another API call. In the Faber browser tab, scroll down to the **`POST /issue-credential/send`** and get ready to (but don’t yet) execute the request. Before execution, you need to find some other data to complete the JSON.

First, scroll back up to the **`GET /connections`** API endpoint and execute it. From the result, find the the `connection_id` and copy the value. A little trickier to find is the `credential_definition_id`. Go back to the terminal where you started the Faber agent, and scroll back until you see the text `#3/4 Create a new schema/cred def on the ledger` and then just below that `Cred def Id:`. Copy the text following that label. Another way to get the `credential_definition_id` is to find it by searching the Indy network transactions posted to the ledger browser app. That works well if you are running locally by clicking the `Domain` link and using the search feature. However, that approach is harder to do when running in the browser, because there are many credential definitions on that ledger instance.
First, scroll back up to the **`GET /connections`** API endpoint and execute it. From the result, find the the `connection_id` and copy the value. A little trickier to find is the `cred_def_id`. Go back to the terminal where you started the Faber agent, and scroll back until you see the text `#3/4 Create a new schema/cred def on the ledger` and then just below that `Cred def Id:`. Copy the text following that label. Another way to get the `cred_def_id` is to find it by searching the Indy network transactions posted to the ledger browser app. That works well if you are running locally by clicking the `Domain` link and using the search feature. However, that approach is harder to do when running in the browser, because there are many credential definitions on that ledger instance.

Now we need put into the JSON the data values for the credential. Copy and paste the following between the `attributes` square brackets. Feel free to change the attribute values (but neither the labels nor the names) as you see fit:

Expand Down
2 changes: 1 addition & 1 deletion demo/runners/faber.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ async def main(start_port: int, show_timing: bool = False):
}
offer_request = {
"connection_id": agent.connection_id,
"credential_definition_id": credential_definition_id,
"cred_def_id": credential_definition_id,
"comment": f"Offer on cred def id {credential_definition_id}",
"credential_preview": cred_preview,
}
Expand Down
2 changes: 1 addition & 1 deletion demo/runners/performance.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ async def send_credential(self, cred_attrs: dict, comment: str = None):
{
"connection_id": self.connection_id,
"credential_definition_id": self.credential_definition_id,
"credential_preview": cred_preview,
"credential_proposal": cred_preview,
"comment": comment,
},
)
Expand Down

0 comments on commit 7a7c556

Please sign in to comment.