Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 404 when schema not found #2683

Merged
merged 1 commit into from Dec 18, 2023
Merged

Conversation

jamshale
Copy link
Contributor

Return a 404 from schema get by id endpoints when the schema is not found.

This could probably be applied to other endpoints as well but I'll be going over the anoncreds endpoints in more detail and can look at them when i'm doing that.

Signed-off-by: jamshale <jamiehalebc@gmail.com>
Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jamshale jamshale linked an issue Dec 18, 2023 that may be closed by this pull request
@jamshale jamshale marked this pull request as ready for review December 18, 2023 21:07
@swcurran swcurran merged commit 6c7827e into hyperledger:main Dec 18, 2023
8 checks passed
@jamshale jamshale deleted the feat/1487 branch December 18, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACA-Py returns 200 with "schema": null when no schema found
3 participants