Endorser protocol askar fixes #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
…er_protocol_askar_fixes
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Codecov Report
@@ Coverage Diff @@
## main #1450 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 488 488
Lines 30009 29986 -23
=======================================
- Hits 28757 28735 -22
+ Misses 1252 1251 -1 |
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
…es' into endorser_protocol_askar_fixes
…rotocol_askar_fixes
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
shaangill025
approved these changes
Oct 22, 2021
shaangill025
approved these changes
Oct 22, 2021
shaangill025
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add askar support to integration test script (
BDD_EXTRA_AGENT_ARGS="{\"wallet-type\":\"askar\"}" ./demo/run_bdd)Fix database locking errors (similar issues as were fixed in PR #1439)
Fix/cleanup unit tests
./run_bddall tests pass (indy-sdk, default wallet)ACAPY_ARG_FILE=postgres-indy-args.yml ./run_bddall tests pass (indy-sdk, postgres wallet)BDD_EXTRA_AGENT_ARGS="{\"wallet-type\":\"askar\"}" ./run_bddall tests pass (askar/credx, default wallet)BDD_EXTRA_AGENT_ARGS="{\"wallet-type\":\"askar\"}" ACAPY_ARG_FILE=postgres-indy-args.yml ./run_bddall tests pass (askar/credx, postgres wallet)