Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when connection request is received (askar, public invitation) #1508

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

baegjae
Copy link
Contributor

@baegjae baegjae commented Nov 22, 2021

This PR fixes error when connection request is received with public invitation under askar

Environment

  • connections/1.0 protocol
  • public invitation
  • askar

Problem

Faber (invitation creator) encountered error below, when connection request was received.

2021-11-22 17:39:38,849 aries_cloudagent.core.dispatcher ERROR Handler error: Dispatcher.handle_message
Traceback (most recent call last):
  File "/Users/baegjae/src/aries-cloudagent-python/aries_cloudagent/core/dispatcher.py", line 197, in handle_message
    await handler(context, responder)
  File "/Users/baegjae/src/aries-cloudagent-python/aries_cloudagent/protocols/connections/v1_0/handlers/connection_request_handler.py", line 41, in handle
    await mgr.receive_request(
  File "/Users/baegjae/src/aries-cloudagent-python/aries_cloudagent/protocols/connections/v1_0/manager.py", line 592, in receive_request
    my_info = await wallet.create_local_did(DIDMethod.SOV, KeyType.ED25519)
  File "/Users/baegjae/src/aries-cloudagent-python/aries_cloudagent/wallet/askar.py", line 199, in create_local_did
    await self._session.handle.insert_key(
AttributeError: 'NoneType' object has no attribute 'insert_key'

wallet was inactive (=handle was None) when creating local did.

Fix

This PR make wallet active to create local did.

Signed-off-by: Ethan Sung baegjae@gmail.com

…under askar

Signed-off-by: Ethan Sung <baegjae@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021

Codecov Report

Merging #1508 (b4a7666) into main (c536635) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1508   +/-   ##
=======================================
  Coverage   95.79%   95.79%           
=======================================
  Files         509      509           
  Lines       30983    30985    +2     
=======================================
+ Hits        29681    29683    +2     
  Misses       1302     1302           

@ianco ianco merged commit 9224d3f into hyperledger:main Nov 23, 2021
@baegjae baegjae deleted the fix-askar-public-invitation branch November 24, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants