Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings when generating ReadTheDocs #1509

Merged
merged 3 commits into from
Nov 23, 2021

Conversation

shaangill025
Copy link
Contributor

Signed-off-by: shaangill025 gill.shaanjots@gmail.com

  • resolves Oddity in the "vc" module when generating ReadTheDocs docs -- a bug? #1506
  • For duplicated object description, renamed references in __init__.py:
    • vc.ld_proofs.crypto, vc.ld_proofs.purposes, vc.ld_proofs.suites by adding a _ when importing modules. Modified vc.ld_proofs to accomodate these changes
    • vc.vc_ld.models by adding a _ when importing modules. Modified vc.vc_ld accordingly
  • For cross-reference warnings, adopted solution from here.
  • Regardinglist not hashable issue in aries_cloudagent/protocols/issue_credential/v1_0/models/credential_exchange.py, I think there was a minor bug/typo, we had credential_request: [Mapping, IndyCredRequest] = None instead of credential_request: Union[Mapping, IndyCredRequest] = None.

Signed-off-by: shaangill025 <gill.shaanjots@gmail.com>
Signed-off-by: shaangill025 <gill.shaanjots@gmail.com>
@shaangill025
Copy link
Contributor Author

@swcurran This should fix all warnings, can you please check on your end?

Copy link
Member

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@swcurran swcurran merged commit c536635 into hyperledger:main Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oddity in the "vc" module when generating ReadTheDocs docs -- a bug?
2 participants