fix: always notify if revocation notification record exists

[TimoGlastra]

Removes the check to notify in the on_revocation_published event handler. This check in the on_revocation_published would only take the global config option into account, meaning it doesn't matter if you provided notify: true in the /revoke endpoint.

ARevNotificationRecord is only created if a notification should be sent (either global agent config, or notify prop in the revoke endpoint). So if a record exists I think we can assume that a notification should be sent as otherwise the record wouldn't exist in the first place. Maybe I'm missing something?

aries-cloudagent-python/aries_cloudagent/revocation/manager.py

Lines 116 to 126 in 681e9aa

	if notify:
	thread_id = thread_id or f"indy::{rev_reg_id}::{cred_rev_id}"
	rev_notify_rec = RevNotificationRecord(
	rev_reg_id=rev_reg_id,
	cred_rev_id=cred_rev_id,
	thread_id=thread_id,
	connection_id=connection_id,
	comment=comment,
	)
	async with self._profile.session() as session:
	await rev_notify_rec.save(session, reason="New revocation notification")

[codecov-commenter]

Codecov Report

Merging #1665 (1f8453c) into main (535f14e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1665      +/-   ##
==========================================
- Coverage   95.50%   95.50%   -0.01%     
==========================================
  Files         528      528              
  Lines       32738    32736       -2     
==========================================
- Hits        31266    31264       -2     
  Misses       1472     1472              

[dbluhm]

Away from a computer ATM so not the most thorough of reviews but the changes look good and reasoning seem reasonable :)