fix: Resolve Revocation Notification environment variable name collision #1751
Conversation
`--monitor-revocation-notification` and `--notify-revocation` have a name conflict with their corresponding environment variables. Now they don't have a conflict. Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
Codecov Report
@@ Coverage Diff @@
## main #1751 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 528 528
Lines 33141 33141
=======================================
Hits 31563 31563
Misses 1578 1578 |
aries_cloudagent/config/argparse.py
Outdated
| @@ -680,7 +680,7 @@ def add_arguments(self, parser: ArgumentParser): | |||
| parser.add_argument( | |||
| "--monitor-revocation-notification", | |||
| action="store_true", | |||
| env_var="ACAPY_NOTIFY_REVOCATION", | |||
| env_var="ACAPY_MONITOR_REVOCATION_NOTIF", | |||
There was a problem hiding this comment.
Nit, but I like it when the env variable follows the argument (so I could guess what the env name is from the arg name)
| env_var="ACAPY_MONITOR_REVOCATION_NOTIF", | |
| env_var="ACAPY_MONITOR_REVOCATION_NOTIFICATION", |
There was a problem hiding this comment.
Fair enough on you're point, let's make that change
aries_cloudagent/config/argparse.py
Outdated
| @@ -680,7 +680,7 @@ def add_arguments(self, parser: ArgumentParser): | |||
| parser.add_argument( | |||
| "--monitor-revocation-notification", | |||
| action="store_true", | |||
| env_var="ACAPY_NOTIFY_REVOCATION", | |||
| env_var="ACAPY_MONITOR_REVOCATION_NOTIF", | |||
There was a problem hiding this comment.
The abbreviation feels slightly out of place but it's also one of the longest monitoring subjects so I'm not feeling particularly nit-picky on that point
There was a problem hiding this comment.
That's the main reason why I shortened it, because it's such a long environment variable
There was a problem hiding this comment.
https://developer.apple.com/documentation/coremedia/1489454-cmmetadataformatdescriptioncreat I mean, could be worse .... 🙃
Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
…cation-env-var-names Signed-off-by: Colton Wolkins (Indicio work address) <colton@indicio.tech>
--monitor-revocation-notificationand--notify-revocationhave aname conflict with their corresponding environment variables. Now they
don't have a conflict.
Signed-off-by: Colton Wolkins (Indicio work address) colton@indicio.tech