Fix IssuerCredRevRecord state update on revocation publish

[andrewwhitehead]

Fixes #1823 broken in #1804

Ran against integration tests T002-TAA and T003-TAA which were previously failing.

[swcurran]

@shaangill025 @ianco --- would really appreciate your review and assessment of this change. Working?

[andrewwhitehead]

Looks like Github webhooks are currently in degraded status

[codecov-commenter]

Codecov Report

Merging #1827 (213d2fa) into main (4240fa9) will increase coverage by 0.01%.
The diff coverage is 73.07%.

@@            Coverage Diff             @@
##             main    #1827      +/-   ##
==========================================
+ Coverage   93.70%   93.71%   +0.01%     
==========================================
  Files         534      534              
  Lines       33871    33879       +8     
==========================================
+ Hits        31738    31750      +12     
+ Misses       2133     2129       -4     

[ianco]

If you're running with a ledger that requires TAA acceptance you need to run faber with --accept-taa (or something like that)

[shaangill025]

@T002-TAA and @T003-TAA are passing, but with @T003-TAA I get the following:

Aries      | Credential: state = done, cred_ex_id = ba2c035d-bd42-4854-8008-1803f8caf13a
    And "Faber" attempts to revoke the credential                                                                     # features/steps/0453-issue-credential.py:150
INFO:aiohttp.access:172.17.0.1 [21/Jun/2022:06:46:20 +0000] "POST /webhooks/topic/issuer_cred_rev/ HTTP/1.1" 200 149 "-" "Python/3.6 aiohttp/3.8.1"
INFO:aiohttp.access:172.17.0.1 [21/Jun/2022:06:46:20 +0000] "POST /webhooks/topic/issue_credential_v2_0/ HTTP/1.1" 200 149 "-" "Python/3.6 aiohttp/3.8.1"
Aries      | Credential: state = credential-revoked, cred_ex_id = ba2c035d-bd42-4854-8008-1803f8caf13a
Aries      | 2022-06-21 06:46:20,187 aries_cloudagent.admin.server ERROR Handler error with exception: Ledger rejected transaction request: client request invalid: InvalidClientTaaAcceptanceError('KHhfaCWgMjuqexPTNh56Hn', 1655793980145993232, 'Incorrect Txn Author Agreement(digest=e76a2894d2d7fb19cc269d4756401061b478fed5e80c4ed6c6ff7653aaf1c00d) in the request', 202).

[shaangill025]

Tested with Alice-Faber demo, now after revocation and publication, the credential state is revoked as expected.

[andrewwhitehead]

@T002-TAA and @T003-TAA are passing, but with @T003-TAA I get the following:

Aries      | Credential: state = done, cred_ex_id = ba2c035d-bd42-4854-8008-1803f8caf13a
    And "Faber" attempts to revoke the credential                                                                     # features/steps/0453-issue-credential.py:150
INFO:aiohttp.access:172.17.0.1 [21/Jun/2022:06:46:20 +0000] "POST /webhooks/topic/issuer_cred_rev/ HTTP/1.1" 200 149 "-" "Python/3.6 aiohttp/3.8.1"
INFO:aiohttp.access:172.17.0.1 [21/Jun/2022:06:46:20 +0000] "POST /webhooks/topic/issue_credential_v2_0/ HTTP/1.1" 200 149 "-" "Python/3.6 aiohttp/3.8.1"
Aries      | Credential: state = credential-revoked, cred_ex_id = ba2c035d-bd42-4854-8008-1803f8caf13a
Aries      | 2022-06-21 06:46:20,187 aries_cloudagent.admin.server ERROR Handler error with exception: Ledger rejected transaction request: client request invalid: InvalidClientTaaAcceptanceError('KHhfaCWgMjuqexPTNh56Hn', 1655793980145993232, 'Incorrect Txn Author Agreement(digest=e76a2894d2d7fb19cc269d4756401061b478fed5e80c4ed6c6ff7653aaf1c00d) in the request', 202).

I think this is part of the test. The ledger transaction is rejected, but it checks the revoked state of the credential anyway.

[ianco]

I think this is part of the test. The ledger transaction is rejected, but it checks the revoked state of the credential anyway.

That's correct, the test puts the wallet into a state where the ledger write will fail, to test the recovery method.

[ianco]

lgtm