Indy ledger fixes and cleanups #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewwhitehead
force-pushed
the
fix/cred-def-not-found
branch
4 times, most recently
from
eb2cf53
to
06e5ae6
Compare
andrewwhitehead
changed the title
…plementation to base class, fixes indentation error in indy_vdr method; cleanups Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
fix/cred-def-not-found
branch
from
06e5ae6
to
0830d18
Compare
shaangill025
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_existing_schema,create_and_send_schemaandcreate_and_send_credential_definitionto theBaseLedgerclass, to avoid duplication betweenIndySdkLedgerandIndyVdrLedgerbackendscreate_and_send_credential_definitioninIndyVdrLedgerIndySdkLedgerI think this should resolve the most common integration test failures (published cred def not found in wallet).