Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting and grammatical errors in different readme's #2222

Merged
merged 9 commits into from
May 8, 2023

Conversation

ff137
Copy link
Contributor

@ff137 ff137 commented May 2, 2023

I noticed some of the docs contain formatting errors and could do with some improved spelling/grammar. Content stays the same.

List of files changed:

Very minor linting improvements, such as indenting or languages added for better code block formatting:

  • DIDMethods.md
  • DIDResolutions.md
  • Multitenancy.md
  • UnitTests.md

Spellchecked as well (shoutout to GPT-4):

  • AdminAPI.md
  • AnoncredsProofValidation.md
  • UsingOpenAPI.md

There are too many readme's to make a bunch more minor edits. Most others seem fine, but these above could do with improvement

ff137 added 2 commits May 2, 2023 19:42
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
@ff137 ff137 changed the title Fix formatting and grammatical errors in different readme' Fix formatting and grammatical errors in different readme's May 2, 2023
ff137 added 2 commits May 2, 2023 19:53
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
ff137 added 4 commits May 2, 2023 20:25
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
@ff137 ff137 marked this pull request as ready for review May 2, 2023 18:32
@sonarcloud
Copy link

sonarcloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome -- thanks! Looks good --scanned the changes in diff and rich presentation modes.

@swcurran swcurran merged commit 99b9e37 into hyperledger:main May 8, 2023
@ff137 ff137 deleted the fix/formatting branch July 4, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants