Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve definitions.py fix to fix backwards compatibility break in plugins #2255

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

usingtechnology
Copy link
Contributor

@usingtechnology usingtechnology commented Jun 5, 2023

Include searching by the module base package when resolving plugin definitions location.

Fixes #2224

This still depends on the module package names and file system paths matching up, which is not guaranteed. But without adding additional configuration in the plugin registry, I think this is all we can do.

Include searching by the module base package when resolving plugin definitions location.

Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
Copy link
Member

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. I'll follow up on testing with the example plugin I referred to #2224 in response to your comments on the same issue!

aries_cloudagent/core/util.py Outdated Show resolved Hide resolved
Signed-off-by: Jason Sherman <tools@usingtechnolo.gy>
@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran
Copy link
Member

swcurran commented Jun 6, 2023

@dbluhm — not clear on your comment above. Do you want to test the #2224 issue before we merge, or are you good with the solution we have?

@dbluhm
Copy link
Member

dbluhm commented Jun 6, 2023

I am hoping to test myself first -- not that I don't trust the fix lol just want to verify the fix and my understanding before calling it good. I can run it through a couple of plugins in addition to the minimal example provided in #2224

Copy link
Member

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working for at least one of our plugins that was previously broken. Thanks!

Reference: Indicio-tech/aries-acapy-plugin-data-transfer#5

@swcurran swcurran merged commit 7a26c20 into hyperledger:main Jun 7, 2023
9 checks passed
@swcurran
Copy link
Member

swcurran commented Jun 7, 2023

@dbluhm — should this trigger a new release — presumably 0.8.2?

@dbluhm
Copy link
Member

dbluhm commented Jun 7, 2023

Yes

@swcurran swcurran changed the title Resolve definitions.py fix Resolve definitions.py fix to fix backwards compatibility break in plugins Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: plugin defined protocols not working in 0.8.1
3 participants