Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose adding Jason Sherman usingtechnology as a Maintainer #2263

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Propose adding Jason Sherman usingtechnology as a Maintainer #2263

merged 2 commits into from
Jun 13, 2023

Conversation

swcurran
Copy link
Member

@swcurran swcurran commented Jun 9, 2023

Signed-off-by: Stephen Curran swcurran@gmail.com

@swcurran
Propose adding Jason Sherman usingtechnology as a Maintainer
c226a1e 
Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran
Copy link
Member Author

swcurran commented Jun 9, 2023

We are proposing that Jason Sherman (@usingtechnology ) be added as an ACA-Py maintainer. He has met the qualifications to be a Maintainer, and the BC Gov Digital Trust team supports he be given this responsibilities. His merged PRs to date include: #2261 #2255 #2245 #2236 #2232 #2230.

This PR also corrects the Maintainers list by adding @ianco. As he is on the "Committers" team, he is by definition a Maintainer. I missed including him in PR #2258. @ianco recently left the BC Gov Digital Trust team ☹️ . I'm not sure if he is willing to continue to be a Maintainer, or if he should move to be a "Maintainer Emeritus". We'd be happy for him to stay as a Maintainer!

@swcurran
Copy link
Member Author

swcurran commented Jun 9, 2023

@hyperledger/aries-cloudagent-python-committers @hyperledger/aries-admins -- we need multiple approvals on this PR to merge it. We will discuss this on the upcoming ACA-Pug meeting --- June 13, 2023.

@ianco
Copy link
Member

ianco commented Jun 10, 2023

This PR also corrects the Maintainers list by adding @ianco. As he is on the "Committers" team, he is by definition a Maintainer. I missed including him in PR #2258. @ianco recently left the BC Gov Digital Trust team ☹️ . I'm not sure if he is willing to continue to be a Maintainer, or if he should move to be a "Maintainer Emeritus". We'd be happy for him to stay as a Maintainer!

Happy to remain as maintainer!

@swcurran swcurran merged commit 4c8e74e into hyperledger:main Jun 13, 2023
14 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran swcurran deleted the add-sherman branch July 4, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianco ianco ianco approved these changes

@dhh1128 dhh1128 dhh1128 approved these changes

@WadeBarnes WadeBarnes WadeBarnes approved these changes

@andrewwhitehead andrewwhitehead andrewwhitehead approved these changes

@dbluhm dbluhm dbluhm approved these changes

@TimoGlastra TimoGlastra TimoGlastra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@swcurran @ianco @dhh1128 @WadeBarnes @andrewwhitehead @dbluhm @TimoGlastra