Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyld version to 2.0.4 #2795

Merged
merged 4 commits into from
Feb 17, 2024
Merged

Conversation

PatStLouis
Copy link
Contributor

This is to address a bug we have found in the pyld library which was incorrectly asserting context elements as null.

Addresses issue #2743 and will close PR #2744.

For background information you can read this closed issue on the pyld repo.

@swcurran I tested these changes and was able to verify traceable credentials with the proper did document content.

@swcurran
Copy link
Member

I’ll watch for the tests, and we’ll include this in the pending release candidate.

@jamshale
Copy link
Contributor

I’ll watch for the tests, and we’ll include this in the pending release candidate.

A couple of the integration tests have been failing a lot today. I'm not sure why, as they had been passing consistently. Might be a resources and timing issue. I ran the failing test locally on main and it passed. Pretty sure we can ignore this fail if we want.

@PatStLouis
Copy link
Contributor Author

PatStLouis commented Feb 17, 2024

From the available logs the step that failed seems due to a cred_def being on the ledger but not in the agent's wallet. Sounds like a false positive as in not related to this PR, do you have the ability to rerun the tests @jamshale ? We had occurrences before where the tests sometimes fail for some arbitrary reason, probably resource or timing issue like you mentioned.

@PatStLouis
Copy link
Contributor Author

I triggered a re-run be updating the branch, lets see

@swcurran
Copy link
Member

Add I merged another PR, so you are out of date again. Update and I will bypass the protections..,

Copy link

sonarcloud bot commented Feb 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@swcurran swcurran merged commit 27bce43 into hyperledger:main Feb 17, 2024
7 of 8 checks passed
@PatStLouis PatStLouis deleted the pstlouis/bump-pyld branch February 17, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants