Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace reports - exchange-specific tracing; proof exchange tracing #451

Merged
merged 28 commits into from Apr 15, 2020

Conversation

ianco
Copy link
Member

@ianco ianco commented Apr 7, 2020

Still a few outstanding TODO's, but opening up the PR to get some eyes on it.

Adds exchange-specific tracing (adds a "trace" attribute to the exchange records as well as admin API inputs and outputs).

Added tracing to proof exchange and credential exchange.

Added support to the alice/faber demo to support tracing to standard log and http endpoint.

TODO:

  • append trace logs to messages is partially implemented - need to either finish this or rip out the code
  • had to add reference to the EFK docker network into the test and demo scripts - need to clean this up - FIXED
  • also need to look into the implications for message forwarding and routing ...
  • anything else from the reviews ...

ianco added 16 commits March 30, 2020 13:26
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
@lgtm-com
Copy link

lgtm-com bot commented Apr 7, 2020

This pull request introduces 1 alert when merging 79f3254 into caf4572 - view on LGTM.com

new alerts:

  • 1 for __eq__ not overridden when adding attributes

@ianco ianco changed the title W.I.P. Trace reports Trace reports - exchange-specific tracing; proof exchange tracing Apr 7, 2020
@ianco
Copy link
Member Author

ianco commented Apr 7, 2020

This pull request introduces 1 alert when merging 79f3254 into caf4572 - view on LGTM.com

new alerts:

  • 1 for eq not overridden when adding attributes

Fixed

@ianco ianco marked this pull request as ready for review April 7, 2020 22:31
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
@codecov-io
Copy link

codecov-io commented Apr 9, 2020

Codecov Report

Merging #451 into master will decrease coverage by 0.04%.
The diff coverage is 83.45%.

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
- Coverage   90.60%   90.55%   -0.05%     
==========================================
  Files         248      249       +1     
  Lines       12216    12455     +239     
==========================================
+ Hits        11068    11279     +211     
- Misses       1148     1176      +28     

Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
@ianco
Copy link
Member Author

ianco commented Apr 14, 2020

Will likely have further changes but I'd like to get this PR merged and into a release (even a beta release) so we can get this deployed/tested on OpenShift

@andrewwhitehead andrewwhitehead merged commit a196335 into hyperledger:master Apr 15, 2020
@ianco ianco deleted the trace_reports_3 branch December 2, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants