respond with 404 Not Found for bad cred ex id in issue-cred #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sklump <srklump@hotmail.com>
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
=======================================
Coverage 96.45% 96.45%
=======================================
Files 236 236
Lines 12123 12135 +12
=======================================
+ Hits 11693 11705 +12
Misses 430 430 |
|
Cool - I'm going to see if I can use the AATH to test this... I'll use Stephen's branch, so please keep that in place for a little bit. |
|
Good news and bad. Super easy to use a another branch in the AATH, so that's neat. I think we can easily make this parameterized so that it's trivial to run these tests with a branch,. Bad is that there were no tests that exercised this, so I couldn't tell if it did anything. |
|
Easy: spin up an instance, get cred Ex record from Admin API specifying bogus cred def id (pick a UUID from the sample black box). Observe the error message, 404 not found. |
|
Also, note that there are unit tests for all of these cases in test_routes.py |
…ent-python into nicer-error-on-issue-cred-wrong-cred-ex-id
andrewwhitehead
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #524 and cousins throughout issue-credential protocol
Signed-off-by: sklump srklump@hotmail.com