Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update revocation demo #644

Merged
merged 11 commits into from Aug 5, 2020
Merged

Update revocation demo #644

merged 11 commits into from Aug 5, 2020

Conversation

nrempel
Copy link
Contributor

@nrempel nrempel commented Jul 31, 2020

Update revocation demo to support old tails server environment variable for backwards compatibility and documentation alignment

Signed-off-by: Nicholas Rempel <nick@lucent.is>
Signed-off-by: Nicholas Rempel <nick@lucent.is>
Signed-off-by: Nicholas Rempel <nick@lucent.is>
@nrempel nrempel requested a review from ianco July 31, 2020 19:59
@nrempel nrempel marked this pull request as draft July 31, 2020 20:00
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2020

Codecov Report

Merging #644 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #644   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files         250      250           
  Lines       13385    13385           
=======================================
  Hits        13211    13211           
  Misses        174      174           

Signed-off-by: Nicholas Rempel <nick@lucent.is>
@nrempel nrempel marked this pull request as ready for review July 31, 2020 20:04
@lgtm-com
Copy link

lgtm-com bot commented Jul 31, 2020

This pull request introduces 2 alerts when merging c286654 into 31f1c87 - view on LGTM.com

new alerts:

  • 2 for Unused import

@ianco
Copy link
Member

ianco commented Aug 3, 2020

Is --revocation supposed to work without an external tail server? When I run ./run_demo faber --revocation without any other parameters/options I get an error:

Traceback (most recent call last):
  File "/home/indy/demo/runners/support/agent.py", line 452, in admin_request
    resp.raise_for_status()
  File "/home/indy/.pyenv/versions/3.6.9/lib/python3.6/site-packages/aiohttp/client_reqrep.py", line 946, in raise_for_status
    headers=self.headers)
aiohttp.client_exceptions.ClientResponseError: 400, message='tails_server_base_url not configured', url=URL('http://192.168.65.3:8021/credential-definitions')

Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
Copy link
Member

@ianco ianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • see pr on the ngrok-wait.sh script
  • when starting faber with --revocation make sure tails url is supplied

@lgtm-com
Copy link

lgtm-com bot commented Aug 4, 2020

This pull request introduces 2 alerts when merging 96a9c9b into 31f1c87 - view on LGTM.com

new alerts:

  • 2 for Unused import

nrempel and others added 3 commits August 4, 2020 09:47
Signed-off-by: Nicholas Rempel <nick@lucent.is>
Signed-off-by: Nicholas Rempel <nick@lucent.is>
andrewwhitehead
andrewwhitehead previously approved these changes Aug 4, 2020
@andrewwhitehead
Copy link
Member

Up to @ianco to approve as it's waiting on his changes requested

demo/AliceGetsAPhone.md Show resolved Hide resolved
demo/runners/support/agent.py Outdated Show resolved Hide resolved
Signed-off-by: Nicholas Rempel <nick@lucent.is>
@ianco ianco merged commit 0c6611c into hyperledger:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants