Ensure no attempt to publish endpoints is made when in read-only mode #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 256 256
Lines 13988 13990 +2
=======================================
+ Hits 13846 13848 +2
Misses 142 142 |
andrewwhitehead
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an error that would cause the agent to try publishing its endpoint when set to work in read-only mode, causing it to crash and exit.
@andrewwhitehead @sklump