refactor: Prepare to support multiple wallets #34
+21
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…property. Signed-off-by: kukgini <kukgini@gmail.com>
2 tasks
|
Altough this PR is titled preparing multiple wallets, My original intention was not to do so when information does not need to be disseminated. Checking wallet is exists or not is sufficient to check the wallet is really there instead of rely on other property. |
|
That makes sense. But, I'm not sure if it's the better decision. Let me think about this later when I replace indy wallet with askar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Checking the actual existance of the file may be a better approach than relying on UserDefault to determine the existence of the wallet.
In this task, I changed the way to manage master secret id. I referenced this from aries-cloudagent-python.
Master secret id is just a label given to the master secret stored in the wallet, so there is no need to create it arbitrarily.