ENH: adds ipa-multipoint library with Pedersen primitives #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-quadratic
force-pushed
the
feature/ipa_multipoint
branch
from
16971c0
to
6284b34
Compare
Rust nativelib for ipa-multipoint includes pedersen hash and pedersen commit These primitives are used by Verkle Tries. Signed-off-by: Thomas Zamojski <thomas.zamojski@quadratic-labs.com>
Signed-off-by: Thomas Zamojski <thomas.zamojski@quadratic-labs.com>
Signed-off-by: Thomas Zamojski <thomas.zamojski@quadratic-labs.com>
matkt
requested changes
Oct 31, 2023
ipa-multipoint/build.gradle
Outdated
| testImplementation 'junit:junit:4.13.2' | ||
| testImplementation 'org.assertj:assertj-core:3.22.0' | ||
| testImplementation 'org.mockito:mockito-core:4.4.0' | ||
| implementation "com.google.guava:guava:16+" |
There was a problem hiding this comment.
do we need guava as implementation or testImplementation ? I will prefer to have a specific version to have a deterministic build
There was a problem hiding this comment.
removed guava as it was unnecessary, and rlp, unit, mockito as well
thomas-quadratic
force-pushed
the
feature/ipa_multipoint
branch
from
ce91d5e
to
78ef66a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ipa-multipoint did not include pedersen hash primitive, and a basic pedersen commit.
This PR improves the library by adding pedersen hashing and revisits pedersen commit.