Linking error potential fix #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neotheprogramist
force-pushed
the
commit-root-rename
branch
from
e690440
to
08ce91a
Compare
|
seems to work . could we add a small description in the PR ? |
|
Shouldn't we have a test in ipa-multipoint/src/test/java/org/hyperledger/besu/nativelib/ipa_multipoint/ for this method as well ? |
neotheprogramist
force-pushed
the
commit-root-rename
branch
from
9163b5b
to
b608aa9
Compare
|
Good with me. Thanks! |
neotheprogramist
force-pushed
the
commit-root-rename
branch
from
d177327
to
6b86956
Compare
neotheprogramist
force-pushed
the
commit-root-rename
branch
from
589fb58
to
70e25ef
Compare
matkt
reviewed
Jan 5, 2024
ipa-multipoint/src/test/java/org/hyperledger/besu/nativelib/ipa_multipoint/CommitRootTest.java
Show resolved
Hide resolved
neotheprogramist
force-pushed
the
commit-root-rename
branch
from
fe8e62a
to
7bb7c43
Compare
Signed-off-by: Neo <neotheprogramist@proton.me>
Signed-off-by: Neo <neotheprogramist@proton.me>
Signed-off-by: Neo <neotheprogramist@proton.me>
Signed-off-by: Neo <neotheprogramist@proton.me>
neotheprogramist
force-pushed
the
commit-root-rename
branch
from
7bb7c43
to
55f04d9
Compare
|
Good for me as well, thanks @neotheprogramist |
kevaundray
pushed a commit
to kevaundray/besu-native
that referenced
this pull request
Jan 24, 2024
Signed-off-by: Neo <neotheprogramist@proton.me> Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses a critical linking error encountered in the Hyperledger Besu native library. The issue came to light following a modification in the method invocation within the
PedersenHasherclass, whereLibIpaMultipoint.commitwas changed toLibIpaMultipoint.commit_root. As a result of this change, ajava.lang.UnsatisfiedLinkErroris triggered when calling thecommit_rootmethod, with the error message:'byte[] org.hyperledger.besu.nativelib.ipamultipoint.LibIpaMultipoint.commit_root(byte[])'.Proposed Fix
The fix proposed in this pull request involves renaming the
commit_rootmethod from snake_case to camelCase. This renaming aims to:Context
While other methods in the
LibIpaMultipointclass, such ascommitandpedersenHash, continue to operate as expected, it is believed that the naming convention employed forcommit_rootmay be contributing to the linking error.