chore: Switch to ffi_interface
#139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
force-pushed
the
kw/update-to-ffi-interface
branch
from
c7bfd13
to
57e6879
Compare
|
Depends on #142 |
kevaundray
force-pushed
the
kw/update-to-ffi-interface
branch
from
08eb67f
to
d6e0ba5
Compare
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
kevaundray
force-pushed
the
kw/update-to-ffi-interface
branch
from
d6e0ba5
to
c950cc7
Compare
kevaundray
commented
Jan 28, 2024
| @@ -27,7 +27,7 @@ jobs: | |||
| export PATH=$GOROOT/bin:$PATH | |||
| # rust dependencies | |||
| export CARGO_HOME="$HOME/.cargo" | |||
| curl https://sh.rustup.rs -sSf | sh -s -- -y --default-toolchain 1.68.2 | |||
| curl https://sh.rustup.rs -sSf | sh -s -- -y --default-toolchain 1.75.0 | |||
There was a problem hiding this comment.
This change was added because CI uses stable and matt was getting an unstable error from one of the newer libraries for a feature which should be stable as of 1.75. (1.68 is quite old)
Signed-off-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
kevaundray
commented
Jan 28, 2024
Comment on lines
57
to
62
| public void testCallLibraryWithMaxElements() { | ||
| Bytes32 element = Bytes32.fromHexString("0xd36f20567f74f607d9252186ff8efed04de4578d1ddb3de4fe6c5e4249e0045b"); | ||
| Bytes32 element = Bytes32.fromHexString("0x006f20567f74f607d9252186ff8efed04de4578d1ddb3de4fe6c5e4249e0045b"); | ||
| Bytes32[] arr = new Bytes32[256]; | ||
| for (int i = 0; i < 256; i++) { | ||
| arr[i] = element; | ||
| } |
There was a problem hiding this comment.
These changes are from #142
…e-to-ffi-interface Signed-off-by: Karim Taam <karim.t2am@gmail.com> # Conflicts: # ipa-multipoint/src/test/resources/genesis_lvl1_commits.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to the new
ffi_interfacefolder and avoids any interface changes by using a global static.The global static should be replaced with a pointer as is done in #138