Added configurable block reward and recipient for IBFT2 #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jframe
reviewed
Jun 23, 2020
consensus/ibft/src/main/java/org/hyperledger/besu/consensus/ibft/IbftProtocolSchedule.java
Outdated
Show resolved
Hide resolved
consensus/ibft/src/main/java/org/hyperledger/besu/consensus/ibft/IbftProtocolSchedule.java
Outdated
Show resolved
Hide resolved
jframe
reviewed
Jun 24, 2020
.../java/org/hyperledger/besu/tests/acceptance/ibft2/Ibft2BlockRewardPaymentAcceptanceTest.java
Show resolved
Hide resolved
config/src/main/java/org/hyperledger/besu/config/IbftConfigOptions.java
Outdated
Show resolved
Hide resolved
| @@ -10,7 +10,8 @@ | |||
| "ibft2": { | |||
| "blockperiodseconds": 1, | |||
| "epochlength": 30000, | |||
| "requesttimeoutseconds": 5 | |||
| "requesttimeoutseconds": 5, | |||
| "blockrewardeth": 5 | |||
There was a problem hiding this comment.
Rather the default was left as 0 as what most people will use and just modify the blockreward for the block reward AT
There was a problem hiding this comment.
Yeah agreed - but it's REALLY hard to do - given no existing tests prove that the validator's not paid, I figured this was ok?
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
jframe
reviewed
Jun 25, 2020
config/src/test/java/org/hyperledger/besu/config/JsonGenesisConfigOptionsTest.java
Show resolved
Hide resolved
Signed-off-by: Trent Mohay <trent.mohay@consensys.net>
jframe
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow IBFT2 to deliver block rewards (of a configurable value), and transaction fees to a configured address.