Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1404] Fixed NPE when executing eth_estimateGas with privacy enabled. #1424

Merged
merged 3 commits into from
Oct 8, 2020

Conversation

mark-terry
Copy link
Contributor

Signed-off-by: Mark Terry mark.terry@consensys.net

PR description

Addresses a bug where an NPE could be encountered when eth_estimateGas is executed when privacy is enabled.

Fixed Issue(s)

Fixes #1404

Changelog

Signed-off-by: Mark Terry <mark.terry@consensys.net>
@mark-terry mark-terry requested a review from pinges October 7, 2020 14:48
@mark-terry mark-terry self-assigned this Oct 7, 2020
@mark-terry mark-terry added TeamRevenant GH issues worked on by Revenant Team privacy private transactions labels Oct 7, 2020
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at my comments.

mark-terry and others added 2 commits October 8, 2020 09:06
Signed-off-by: Mark Terry <mark.terry@consensys.net>
@mark-terry mark-terry merged commit 5c0ee9d into hyperledger:master Oct 8, 2020
@mark-terry mark-terry deleted the 1404 branch October 8, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
privacy private transactions TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE in privacy code
3 participants