Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid error codes on some JSON RPC apis #2138

Merged

Conversation

matkt
Copy link
Contributor

@matkt matkt commented Apr 13, 2021

Signed-off-by: Karim TAAM karim.t2am@gmail.com

PR description

This bugs were found during ethspams testing

  • Fix bad error code when we give a block ahead (http code 200 instead of 400 in this case). In the eip-1898 it is recommended to use -32XXX error code and not -32602 when the block is not found

  • Modify the code so the blockchainQueries classes does not use the persistent worlstate with bonsai trie.

Changelog

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
@matkt matkt changed the title Not use persisting state for the BlockchainQueries class - Bonsai trie Fix invalid error codes on some JSON RPC apis Apr 16, 2021
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM please add a changelog entry

@matkt matkt marked this pull request as ready for review May 7, 2021 08:21
matkt added 3 commits May 7, 2021 10:23
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
@matkt matkt enabled auto-merge (squash) May 7, 2021 08:31
@matkt matkt merged commit 1e2411c into hyperledger:master May 8, 2021
@matkt matkt deleted the feature/bonsai-trie-blockchain-queries-invalid branch March 11, 2022 08:12
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants