Implement eip 3529 #2238
Implement eip 3529 #2238
Conversation
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
| } | ||
|
|
||
| @Test | ||
| public void shouldCalculateGasAccordingToEip3539() { |
| {"0x60016000556000600055", 0, 20112, 19900}, | ||
| {"0x60016000556002600055", 0, 20112, 0}, | ||
| {"0x60016000556001600055", 0, 20112, 0}, | ||
| {"0x60006000556000600055", 1, 3012, 4800}, |
There was a problem hiding this comment.
this would be a good test case for maxRefund <= gasUsed / 5. We don't really cover that case in tests.
There was a problem hiding this comment.
There is no complex logic. Trying to test it I found myself mocking everything. I think it will be more useful to check this part thanks to the reference tests
| // defined in Berlin, but re-implemented with new constants | ||
| @Override | ||
| // As per https://eips.ethereum.org/EIPS/eip-3529 | ||
| public Gas calculateStorageRefundAmount( | ||
| final Account account, final UInt256 key, final UInt256 newValue) { |
There was a problem hiding this comment.
this is identical to the berlin gas calculator, how about just protected accessors for the 2 changed constants? The method is kinda funky to read, that is the only reason I ask
There was a problem hiding this comment.
At first I wanted to do this but it seems that this is what was also done for Berlin/Istanbul. Can be to improve readability or explained that this method has been updated. To maintain a consistency I wanted to keep that but we can in a future PR change that if you find it really necessary
| // redefinitions for EIP-3529 | ||
| private static final Gas SSTORE_CLEARS_SCHEDULE = SSTORE_RESET_GAS.plus(ACCESS_LIST_STORAGE_COST); | ||
|
|
||
| protected static final Gas NEGATIVE_SSTORE_CLEARS_SCHEDULE = |
There was a problem hiding this comment.
this doesn't need to be protected does it? it is only used in this class
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
PR description
Implement eip 3529 (version of the spec ethereum/EIPs@6079eba)
Fixed Issue(s)
Changelog