Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install solc in CI; specify solidity version for web3j plugin #3183

Merged
merged 8 commits into from
Dec 16, 2021

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Dec 16, 2021

Signed-off-by: Sally MacFarlane sally.macfarlane@consensys.net

  • install solc on CI executor
  • specify version of solidity
  • update pragma of all solidity files to allow 0.8
  • two minor changes to solidity so it compiles under solc 0.8

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@macfarla macfarla changed the title specify solidity version install solc in CI; specify solidity version for web3j plugin Dec 16, 2021
@fab-10 fab-10 mentioned this pull request Dec 16, 2021
1 task
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit 424ad3c into hyperledger:main Dec 16, 2021
@macfarla macfarla deleted the solidity-plugin-specify-version branch December 16, 2021 10:05
@fab-10 fab-10 added the doc-change-required Indicates an issue or PR that requires doc to be updated label Dec 16, 2021
macfarla added a commit to macfarla/besu that referenced this pull request Dec 16, 2021
…edger#3183)

* specify solidity version

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* different version

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* web3j plugin update

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* uprev pragma to include 0.8

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* install solc

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* 0.8.10

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* remove info

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* ignore two tests

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
taccatisid pushed a commit to taccatisid/besu that referenced this pull request Dec 17, 2021
install solc in CI; specify solidity version for web3j plugin (hyperledger#3183)

* specify solidity version

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* different version

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* web3j plugin update

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* uprev pragma to include 0.8

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* install solc

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* 0.8.10

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* remove info

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* ignore two tests

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

merge changelog - for update log4j version change

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

dl link for 21.10.3

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

fixed changelog to reflect what's actually in 22.10.4

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

unignore test

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

install software-properties-common

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

update first

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

-y

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

one more update

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

repo -y

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

change order

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

use node to install solc

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

solcjs

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

info logging

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

remove maybe unused line

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

docker vulnerabilities change

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

so that was used

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

xfetch statically linked solc binary for tests

Signed-off-by: Taccat Isid <taccatisid@protonmail.com>
taccatisid pushed a commit that referenced this pull request Dec 17, 2021
install solc in CI; specify solidity version for web3j plugin (#3183)

* specify solidity version

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* different version

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* web3j plugin update

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* uprev pragma to include 0.8

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* install solc

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* 0.8.10

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* remove info

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* ignore two tests

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

merge changelog - for update log4j version change

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

dl link for 21.10.3

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

fixed changelog to reflect what's actually in 22.10.4

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

unignore test

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

install software-properties-common

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

update first

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

-y

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

one more update

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

repo -y

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

change order

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

use node to install solc

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

solcjs

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

info logging

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

remove maybe unused line

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

docker vulnerabilities change

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

so that was used

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

xfetch statically linked solc binary for tests

Signed-off-by: Taccat Isid <taccatisid@protonmail.com>
taccatisid pushed a commit that referenced this pull request Dec 17, 2021
install solc in CI; specify solidity version for web3j plugin (#3183)

* specify solidity version

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* different version

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* web3j plugin update

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* uprev pragma to include 0.8

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* install solc

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* 0.8.10

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* remove info

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* ignore two tests

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

merge changelog - for update log4j version change

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

dl link for 21.10.3

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

fixed changelog to reflect what's actually in 22.10.4

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

unignore test

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

install software-properties-common

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

update first

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

-y

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

one more update

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

repo -y

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

change order

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

use node to install solc

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

solcjs

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

info logging

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

remove maybe unused line

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

docker vulnerabilities change

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

so that was used

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

xfetch statically linked solc binary for tests

Signed-off-by: Taccat Isid <taccatisid@protonmail.com>
shemnon pushed a commit to shemnon/besu that referenced this pull request Dec 18, 2021
…edger#3183)

* specify solidity version

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* different version

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* web3j plugin update

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* uprev pragma to include 0.8

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* install solc

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* 0.8.10

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* remove info

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* ignore two tests

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

(cherry picked from commit 424ad3c)
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
@bgravenorst bgravenorst removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Mar 4, 2022
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
…edger#3183)

* specify solidity version

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* different version

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* web3j plugin update

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* uprev pragma to include 0.8

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* install solc

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* 0.8.10

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* remove info

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>

* ignore two tests

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants