-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install solc in CI; specify solidity version for web3j plugin #3183
Merged
macfarla
merged 8 commits into
hyperledger:main
from
macfarla:solidity-plugin-specify-version
Dec 16, 2021
Merged
install solc in CI; specify solidity version for web3j plugin #3183
macfarla
merged 8 commits into
hyperledger:main
from
macfarla:solidity-plugin-specify-version
Dec 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
macfarla
changed the title
specify solidity version
install solc in CI; specify solidity version for web3j plugin
Dec 16, 2021
1 task
fab-10
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fab-10
added
the
doc-change-required
Indicates an issue or PR that requires doc to be updated
label
Dec 16, 2021
macfarla
added a commit
to macfarla/besu
that referenced
this pull request
Dec 16, 2021
…edger#3183) * specify solidity version Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * different version Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * web3j plugin update Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * uprev pragma to include 0.8 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * install solc Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * 0.8.10 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * remove info Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * ignore two tests Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
taccatisid
pushed a commit
to taccatisid/besu
that referenced
this pull request
Dec 17, 2021
install solc in CI; specify solidity version for web3j plugin (hyperledger#3183) * specify solidity version Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * different version Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * web3j plugin update Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * uprev pragma to include 0.8 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * install solc Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * 0.8.10 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * remove info Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * ignore two tests Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> merge changelog - for update log4j version change Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> dl link for 21.10.3 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> fixed changelog to reflect what's actually in 22.10.4 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> unignore test Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> install software-properties-common Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> update first Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> -y Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> one more update Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> repo -y Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> change order Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> use node to install solc Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> solcjs Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> info logging Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> remove maybe unused line Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> docker vulnerabilities change Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> so that was used Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> xfetch statically linked solc binary for tests Signed-off-by: Taccat Isid <taccatisid@protonmail.com>
taccatisid
pushed a commit
that referenced
this pull request
Dec 17, 2021
install solc in CI; specify solidity version for web3j plugin (#3183) * specify solidity version Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * different version Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * web3j plugin update Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * uprev pragma to include 0.8 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * install solc Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * 0.8.10 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * remove info Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * ignore two tests Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> merge changelog - for update log4j version change Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> dl link for 21.10.3 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> fixed changelog to reflect what's actually in 22.10.4 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> unignore test Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> install software-properties-common Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> update first Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> -y Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> one more update Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> repo -y Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> change order Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> use node to install solc Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> solcjs Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> info logging Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> remove maybe unused line Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> docker vulnerabilities change Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> so that was used Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> xfetch statically linked solc binary for tests Signed-off-by: Taccat Isid <taccatisid@protonmail.com>
taccatisid
pushed a commit
that referenced
this pull request
Dec 17, 2021
install solc in CI; specify solidity version for web3j plugin (#3183) * specify solidity version Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * different version Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * web3j plugin update Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * uprev pragma to include 0.8 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * install solc Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * 0.8.10 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * remove info Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * ignore two tests Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> merge changelog - for update log4j version change Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> dl link for 21.10.3 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> fixed changelog to reflect what's actually in 22.10.4 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> unignore test Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> install software-properties-common Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> update first Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> -y Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> one more update Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> repo -y Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> change order Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> use node to install solc Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> solcjs Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> info logging Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> remove maybe unused line Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> docker vulnerabilities change Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> so that was used Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> xfetch statically linked solc binary for tests Signed-off-by: Taccat Isid <taccatisid@protonmail.com>
shemnon
pushed a commit
to shemnon/besu
that referenced
this pull request
Dec 18, 2021
…edger#3183) * specify solidity version Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * different version Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * web3j plugin update Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * uprev pragma to include 0.8 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * install solc Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * 0.8.10 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * remove info Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * ignore two tests Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> (cherry picked from commit 424ad3c) Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
bgravenorst
removed
the
doc-change-required
Indicates an issue or PR that requires doc to be updated
label
Mar 4, 2022
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…edger#3183) * specify solidity version Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * different version Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * web3j plugin update Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * uprev pragma to include 0.8 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * install solc Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * 0.8.10 Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * remove info Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> * ignore two tests Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sally MacFarlane sally.macfarlane@consensys.net