allow upgrade whether websockets enabled or not #4019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jflo
added
the
doc-change-required
jflo
commented
Jun 28, 2022
|
|
||
| assertThat(runner.getEngineJsonRpcPort()).isPresent(); | ||
| runner.startExternalServices(); | ||
| //assert that rpc method collection has eth_subscribe in it. |
There was a problem hiding this comment.
Couldn't find any good way to inspect this, will add integration test to cover it.
Signed-off-by: Justin Florentine <justin+github@florentine.us>
jflo
force-pushed
the
3948-subscribe-on-engine2
branch
from
e449b59
to
00da06b
Compare
rolandtyler
removed
the
doc-change-required
garyschulte
added a commit
that referenced
this pull request
Jul 7, 2022
49e4fd8 -> worldstate not avail (#4069) 6aa8812 -> stateroot mismatch (#4041) 043191a -> jwt auth on websockets (#4039) 90f891b -> do not move head on exec and propose (#4013) 3baa4da -> upgrade for websockets (#4019) 5024c07 -> sepolia TTD (#4024) 5ee9be8 -> heal step in snap (#3920) 261b1e0 -> remove peer block height requirements (#3911) Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
added a commit
that referenced
this pull request
Jul 7, 2022
49e4fd8 -> worldstate not avail (#4069) 6aa8812 -> stateroot mismatch (#4041) 043191a -> jwt auth on websockets (#4039) 90f891b -> do not move head on exec and propose (#4013) b5fa62c -> sync check before processing remote transactions (4035) 3baa4da -> upgrade for websockets (#4019) 5024c07 -> sepolia TTD (#4024) 5ee9be8 -> heal step in snap (#3920) 261b1e0 -> remove peer block height requirements (#3911) Signed-off-by: garyschulte <garyschulte@gmail.com>
Merged
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* allow upgrade whether websockets enabled or not Signed-off-by: Justin Florentine <justin+github@florentine.us> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Florentine justin+github@florentine.us
fixes #3948